Don't check twice if there is a ':' in content (EmojiFilter) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -17,7 +17,7 @@ class EmojiFilter < Filter | |||
| def call | |||
| doc.search('text()').each do |node| | |||
| content = node.to_html | |||
| next if !content.include?(':') | |||
| next unless content.include?(':') | |||
There was a problem hiding this comment.
No need to back this change out, but for future reference, keep PR's focused to what you're trying to solve to make code reviews easier 😉
There was a problem hiding this comment.
I added this change, because it was directly related to the refactored LOC. I should have promoted this change more clearly in the PR description. Thank's fore merging anyway 🍻
jch
added a commit
that referenced
this pull request
Sep 15, 2014
Don't check twice if there is a ':' in content (EmojiFilter)
|
Nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second check if there is a
:in a text is not needed, since it's already done before.